Brings automatic weaponry to the marine and surv arsenal #4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zonespace27
added
Balance
harryob
approved these changes
Jul 27, 2023
3 tasks
morrowwolf
added
Testmerge Candidate
harryob
reviewed
Aug 22, 2023
3 tasks
harryob
approved these changes
Aug 23, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
cm13-github
added a commit
that referenced
this pull request
Aug 23, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> # About the pull request Gives the m56d full auto. Refactors a lot of m56d/m2c code to make this possible. Test merge first. Also gives the m56d an ammo counter on-firing. Does not apply to the M2C. # Explain why it's good for the game This was planned for #4003, but was too far out of scope to be done in that PR. Automatic mode is better from a user QOL standpoint, and shouldn't affect balance much. # Testing Photographs and Procedure <!-- Include any screenshots/videos/debugging steps of the modified code functioning successfully, ideally including edge cases. --> <details> <summary>Screenshots & Videos</summary> Works </details> # Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly label your changes in the changelog. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> <!-- If you add a name after the ':cl', that name will be used in the changelog. You must add your CKEY after the CL if your GitHub name doesn't match. Maintainers freely reserve the right to remove and add tags should they deem it appropriate. --> :cl: balance: M56D now has full auto mode. qol: M56D now has an ammo counter when firing. del: M2C can no longer rotate with MMB /:cl: <!-- Both :cl:'s are required for the changelog to work! -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Gives full auto to the following guns:
m41a (and mk1)
m39
HPR (when bipodded)
m46c in IFF off
type71
mar40
nsg
every civvie SMG except the nailgun
laser uzi
All newly automatic guns fire 20% slower in automatic mode, to balance for the fact that it is much easier to re-aim than burst.
This creates a dynamic between the three firemodes:
Semi:
Burst:
Auto:
Explain why it's good for the game
Guns not having autofire feels... pretty rough. This PR will bring CM to a more modern time, while reducing the number of players diagnosed with carpal tunnel yearly.
Testing Photographs and Procedure
I went through and tested pretty much every base gun, but I cannot guarantee that they all handle well. Lemme know if something's off.
Changelog
🆑
balance: The M41A, M41Amk1, m39, m46c (iff off), mar-30/40/60, type 71, laser uzi, and every SMG now has automatic fire. To compensate for the ability to re-aim (unlike burst), the guns fire 20% slower while automatic. This does not apply to already-existing automatic weaponry.
balance: The HPR can now fire in full auto when bipodded.
fix: Adding/removing attachments now keeps the current firemode, if possible.
fix: The dualtube and spec sniper now can switch tubes/toggle laser again
fix: Fixed a long-standing exploit with bipods and scopes.
fix: Fixed guns jamming when shooting UI elements.
fix: Fixed a bunch of guns unintentionally having burst.
balance: You can transfer ammo between HPR ammo boxes by hitting one with another.
/:cl: